Feature intl + reverse proxy

AndreMiras / edilkamin

Unofficial Edilkamin webapp

https://edilkamin.vercel.app

2 stars 1 forks source link

Feature intl + reverse proxy #4

Open floviolleau opened 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
edilkamin	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 7, 2023 at 10:02AM (UTC)

AndreMiras commented 1 year ago

Hi @floviolleau, thanks a mil for the PR. It's a bit too big and I may have too many comments. Here are a few questions/comments I have already:

make a PR with only the reverse proxy part (I'm currently not clear what's doing)
one with only the translation
why the dependency reorg?
for the linting we already use prettier, use yarn format to apply
not clear to me why is the fireplace regex change

floviolleau commented 1 year ago

Hi,

Just a quick answer. I'm a bit busy right now. I will take care of all remarks soon

Regards

floviolleau commented 11 months ago

Hi,

I'm not forgetting this PR 😉

I'm very busy at work and I don't really want to spend time to split the PR into more PR because I did lot's of manual tests.

See this PR as architecture changes to put foundations for future devs 😉.

I will take care of your comments of the review.

Why adding proxy support? It's because I have a server that proxy all requests to corresponding server and doing the dispatch.

I did a reorg of dependencies because some where in deps instead of being in devDeps and as far as I remember, I organized it alphabetically (and added more)

I didn't checked prettier.

Kind regards

AndreMiras commented 11 months ago

Thanks for getting back. I understand you're busy on other things and thanks again for taking time to look into it. Then if you don't mind I can cherry pick your commits later then rework and integrate them as I see fit, you would still appear as the author of the commit I would cherry pick