search

AndreMiras / gitpop3

Find the most popular fork on GitHub
https://andremiras.github.io/gitpop3/
125 stars 6 forks source link

Use pagination params to pull from API #5

Closed AndreMiras closed 3 years ago

AndreMiras commented 3 years ago

Currently the pagination is only used when rendering the table, refs #2. Ideally we should also supply the pagination parameters when pulling from the GraphQL API

AndreMiras commented 3 years ago

The GitHub GraphQL API doesn't make it entirely possible as it only allows to order by a few columns, but not all of them. That's why the sorting will always be stargazers and later sorted frontend side, also see b790e067a4485bf4f040061d51f5c04af1daec78