search

AndreRenaud / simple_uart

Simple cross-platform UART/Serial library
BSD Zero Clause License
13 stars 4 forks source link

Linux Crosscompile for Windows fails #34

Closed andkae closed 10 months ago

andkae commented 10 months ago

Hi André,

at the moment i encounter an issue with case sensitivity and insivity between linux and windows. For compile i use windows-shared-x64. This expects following lib names basetsd.h and setupapi.h. In the simple_uart is following defined: https://github.com/AndreRenaud/simple_uart/blob/511a9e85aa20fe45c629163632d6f121b87dd9db/simple_uart.h#L13 https://github.com/AndreRenaud/simple_uart/blob/511a9e85aa20fe45c629163632d6f121b87dd9db/simple_uart.c#L31

I would change to the lower case spelling. For windows it should make no differences. I can prepare an PR. Any concerns?

BR, Andreas

AndreRenaud commented 10 months ago

Yes, that seems like a good change. Please go ahead

andkae commented 10 months ago

Thanks for merge.