search

Andrea-Fox / peopleCounter

Code for a cheap people counter based on VL53L1X sensor and ESP32/8266
The Unlicense
95 stars 27 forks source link

Code question advised_oriantation_of_the_sensor #14

Closed noxhirsch closed 3 years ago

noxhirsch commented 3 years ago

Shouldn't the switch...case for advised_orientation_of_the_sensor == false also have break;? 

  if (advised_orientation_of_the_sensor){

    switch (ROI_size) {
        case 4:
          center[0] = 150;
          center[1] = 247;
          break;
        case 5:
          center[0] = 150;
          center[1] = 247;
          break;
        case 6:
          center[0] = 159;
          center[1] = 239;
          break;
        case 7:
          center[0] = 159;
          center[1] = 239;
          break;
        case 8:
          center[0] = 167;
          center[1] = 231;
          break;
      }
  }
  else{
    switch (ROI_size) {
        case 4:
          center[0] = 195;
          center[1] = 60;
        case 5:
          center[0] = 194;
          center[1] = 59;
        case 6:
          center[0] = 194;
          center[1] = 59;
        case 7:
          center[0] = 193;
          center[1] = 58;
        case 8:
          center[0] = 193;
          center[1] = 58;

      }
  }
Andrea-Fox commented 3 years ago

You are completely right. I will edit now. Thank you for noticing that as well