AndreaCirilloAC / updateR

update your R version in a breeze ( on OSX) √
Other
143 stars 23 forks source link

Package downloads 3.4 but installs 3.3.2 #15

Open jonathandroth opened 7 years ago

jonathandroth commented 7 years ago

I am currently running 3.3.2 and was hoping to use the package to upgrade to 3.4. I ran the followign code and got the resulting output. It appears to have downloaded 3.4, but I am still on 3.3.2

library(devtools)
install_github("AndreaCirilloAC/updateR")
updateR(admin_password = "[my password]")
trying URL 'https://cran.rstudio.com/bin/macosx/R-3.4.0.pkg'
Content type 'unknown' length 64154371 bytes (61.2 MB)
==================================================
downloaded 61.2 MB

Installing R-3.4.0...please wait
Package "R-3.4.0.pkg":
   Status: signed by a certificate trusted by Mac OS X
   Certificate Chain:
    1. Developer ID Installer: Simon Urbanek
       SHA1 fingerprint: B7 EB 39 5E 03 CF 1E 20 D1 A6 2E 9F D3 17 90 26 D8 D6 3B EF
       -----------------------------------------------------------------------------
    2. Developer ID Certification Authority
       SHA1 fingerprint: 3B 16 6C 3B 7D C4 B7 51 C9 FE 2A FA B9 13 56 41 E3 88 E1 86
       -----------------------------------------------------------------------------
    3. Apple Root CA
       SHA1 fingerprint: 61 1E 5B 66 2C 59 3A 08 FF 58 D1 4A E2 24 52 D1 98 DF 6C 60

Everything went smoothly, R was updated to R version 3.3.2 (2016-10-31) -- "Sincere Pumpkin Patch"
AndreaCirilloAC commented 7 years ago

Hi, thank you for pointing this out, could you kindly provide session info (sessionInfo())? going to get into this. thanks

jonathandroth commented 7 years ago

Sorry for the delay. Here is the sessionInfo:

R version 3.3.2 (2016-10-31)
Platform: x86_64-apple-darwin13.4.0 (64-bit)
Running under: OS X Yosemite 10.10.5

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] updateR_0.1     devtools_1.13.1

loaded via a namespace (and not attached):
 [1] Rcpp_0.12.11  XML_3.98-1.5  digest_0.6.12 withr_1.0.2   R6_2.2.0      git2r_0.18.0 
 [7] magrittr_1.5  httr_1.2.1    stringi_1.1.2 curl_2.3      xml2_1.1.1    tools_3.3.2  
[13] stringr_1.1.0 selectr_0.3-0 rvest_0.3.2   memoise_1.1.0
jebyrnes commented 7 years ago

Same problem, but 3.3 (which is what I'm currently running)

trying URL 'https://cran.rstudio.com/bin/macosx/R-3.4.0.pkg'
Content type 'unknown' length 64154371 bytes (61.2 MB)
==================================================
downloaded 61.2 MB

Installing R-3.4.0...please wait
Package "R-3.4.0.pkg":
   Status: signed by a certificate trusted by Mac OS X
   Certificate Chain:
    1. Developer ID Installer: Simon Urbanek
       SHA1 fingerprint: B7 EB 39 5E 03 CF 1E 20 D1 A6 2E 9F D3 17 90 26 D8 D6 3B EF
       -----------------------------------------------------------------------------
    2. Developer ID Certification Authority
       SHA1 fingerprint: 3B 16 6C 3B 7D C4 B7 51 C9 FE 2A FA B9 13 56 41 E3 88 E1 86
       -----------------------------------------------------------------------------
    3. Apple Root CA
       SHA1 fingerprint: 61 1E 5B 66 2C 59 3A 08 FF 58 D1 4A E2 24 52 D1 98 DF 6C 60

Everything went smoothly, R was updated to R version 3.3.3 (2017-03-06) -- "Another Canoe"

Here's my sessionInfo()

Platform: x86_64-apple-darwin13.4.0 (64-bit)
Running under: OS X El Capitan 10.11.6

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] updateR_0.1

loaded via a namespace (and not attached):
 [1] httr_1.2.1    selectr_0.3-0 R6_2.2.0      magrittr_1.5  tools_3.3.3  
 [6] curl_2.3      Rcpp_0.12.11  xml2_1.1.1    stringi_1.1.5 stringr_1.2.0
[11] rvest_0.3.2   XML_3.98-1.5 
daranzolin commented 7 years ago

Yup, I'm having the same issue. If it helps, here's my sessionInfo():

> sessionInfo()
R version 3.3.3 (2017-03-06)
Platform: x86_64-apple-darwin13.4.0 (64-bit)
Running under: macOS Sierra 10.12.3

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
 [1] httr_1.3.1    selectr_0.3-1 magrittr_1.5  updateR_0.1   R6_2.2.2      rsconnect_0.7 tools_3.3.3   curl_2.8.1    Rcpp_0.12.12 
[10] xml2_1.1.1    stringi_1.1.5 stringr_1.2.0 rvest_0.3.2   XML_3.98-1.6 
ningchencontact commented 6 years ago

same here

`> sessionInfo() R version 3.2.2 (2015-08-14) Platform: x86_64-apple-darwin13.4.0 (64-bit) Running under: OS X 10.10.5 (Yosemite)

locale: [1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages: [1] stats graphics grDevices utils datasets methods
[7] base

other attached packages: [1] updateR_0.1

loaded via a namespace (and not attached): [1] Rcpp_0.12.12 XML_3.98-1.3 digest_0.6.9
[4] withr_1.0.2 R6_2.1.2 git2r_0.13.1
[7] magrittr_1.5 httr_1.3.1 stringi_1.1.5
[10] curl_2.8.1 rpart_4.1-10 xml2_1.1.1
[13] devtools_1.13.3 tools_3.2.2 stringr_1.2.0
[16] selectr_0.3-1 rvest_0.3.2 memoise_1.1.0`

krisrs1128 commented 6 years ago

I think part of the issue is that if the installation fails, it fails silently, because of the ignore.stdout = TRUE and ignore.stderr = TRUE on line 44 of updateR.R:

When I replaced that line with system(command), reinstalled the package, and ran updateR again, I saw that the system command had actually failed, because I needed to update my mac OSX version. After I did that, everything worked.

AndreaCirilloAC commented 6 years ago

Hi, sorry for late reply. @krisrs1128 thanks for the valuable information. If you can test your hypothesis would be of great help for all of us if you could send a pull request.

Thanks,

A

krisrs1128 commented 6 years ago

Hi @AndreaCirilloAC I just created a pull request. In my case printing the error message helped me update my system so that the terminal installation (and hence this package) worked.

Different terminal errors will depend on the actual user (it might not always just be a mac version issue, like it was in my case). But at least this will alert people to what the error might be.

fmerhout commented 6 years ago

One issue for @jonathandroth and @ningchencontact also seems to be that updateR only looks for the most recent R version without confirming that it is compatible with the OS. Both are running OS X (Mavericks) 10.10.5 but R 3.4 is only compatible with OS X 10.11 (El Capitan) and higher.

AndreaCirilloAC commented 6 years ago

this is definitely not implemented, we can add it as a possibile feature to be implemented, even if I don't think one the most urgent.

fmerhout commented 6 years ago

I agree that it is not that urgent; but it might be good to have a note about it in the readme as a heads up.

AndreaCirilloAC commented 6 years ago

@fmerhout point taken, and readme updated.

AndreaCirilloAC commented 6 years ago

@jebyrnes @daranzolin I have made a few changesto the packages, possibly fixing the issue you were experiencing. Could you give updateR() another try and let me know? In case of negative output, could you tell me if and were the 3.4.4.pkg got installed? thanks

toyo10 commented 6 years ago

Still not working for me. Version 3.3. got installed.