search

AndreaCirilloAC / updateR

update your R version in a breeze ( on OSX) √
Other
143 stars 24 forks source link

Some edits to what prints out #2

Closed RobertMyles closed 7 years ago

RobertMyles commented 7 years ago

I thought it would be useful to show a message at the end of the process that prints the R version that the user just updated to, instead of having to open terminal. Also the first time I used this function, I saw "password: " printed to the console, and I thought I had to enter it! :-) So, I stopped all of that part printing.

I also took out the package messages for dplyr, and I put in a password check for the function, and I tidied up the code a little bit to make it easier for people (like me!) to read.

AndreaCirilloAC commented 7 years ago

this is great @RobertMyles ! sorry for this late feedback, I will give a look to your code asap. thank you once more

RobertMyles commented 7 years ago

Hi Andrea, I'm glad you like these! Yes, maybe we could exit the code execution at that point. I originally did that with stop() and stopifnot(), but it gives that ugly error where RStudio stops and goes into debugging mode. If that's what you prefer, then we could do that, but I think inexperienced users of R won't know what's happening, so that's why I preferred the simple warning.

AndreaCirilloAC commented 7 years ago

ok @RobertMyles going to test it shortly. thanks once more