search

AndreaCirilloAC / updateR

update your R version in a breeze ( on OSX) √
Other
143 stars 24 forks source link

updated function #5

Closed RobertMyles closed 7 years ago

RobertMyles commented 7 years ago

I hope this fixes the problems! I added myself as a co-author, I didn't see that you'd already done that, Andrea. I put the documentation through Roxygen too, in case you want to submit to CRAN.

I added in a check of the signature of the install: 

 arg <- paste0("--check-signature ", file)
 system2("pkgutil", arg)

If you think it's unnecessary, feel free to take it out. I've tested this and it works for me, I hope it fixes #3 .

RobertMyles commented 7 years ago

I also wrote basic documentation for the function, but I think the original had more detail.

AndreaCirilloAC commented 7 years ago

Hi @RobertMyles , I have actually already added you as co author within this commit: https://github.com/AndreaCirilloAC/updateR/commit/aac8add4020c7ccdf30d6b34551295531441e2f8 :) I vill have a look soon to your contributions and merge them. thank you once more.