search

AndreaMiotto / PartialSheet

A SwiftUI Partial Sheet fully customizable with dynamic height
https://github.com/AndreaMiotto/PartialSheet/wiki
MIT License
1.73k stars 194 forks source link

Fix bug where using a segmented picker within a PartialSheet leads to unresponsive picker. #165

Closed JuliusHuizing closed 1 year ago

JuliusHuizing commented 2 years ago

Fix bug where using a segmented picker within a PartialSheet leads to unresponsive picker.

Remove call to onTapGesture method in iPhoneSheet builder. As pointed out by @ajevans99, SwiftUI seems to have trouble handling segmented pickers correctly if an onTapGesture method is added to the view that contains the picker. In this case of the iPhone sheet buider, the onTapGesture method call can safely be deleted since it was hardcoded to execute an empty closure. Removing the call should therefore not have any effect except for solving the mentioned bug.

tanigon commented 2 years ago

+1 looking forward to being merged... seriously