search

AndreaMiotto / PartialSheet

A SwiftUI Partial Sheet fully customizable with dynamic height
https://github.com/AndreaMiotto/PartialSheet/wiki
MIT License
1.73k stars 194 forks source link

Partial sheet on top of .sheet() gets cut off #169

Open emilloohoo opened 1 year ago

emilloohoo commented 1 year ago

Our app has a lot of .sheet() modifiers to pop up over our views. We are using your PartialSheet to have an additional popup over our sheet, but are noticing that the edge of the bottom gets cut off, due to the height of the .sheet() behind it. We added the .attachPartialSheetToRoot() to the view that .sheet() encapsulates. I believe that the root view's height is what is used for calculation, so when the root view is a sheet, the height is smaller so the calculated height reduces. I have tried attachPartialSheetToRoot on the .sheet().attachPartialSheetToRoot but that doesn't work at all.

Any ideas to when this can be fixed? We have to add padding right now but want to reuse the view in places that don't have it popup on a sheet and instead just the static view, so we don't want the padding in some cases.

AndreaMiotto commented 1 year ago

Hello, try with the new version, if you still have a problem, can you provide a sample please?