Update ts-eslint/naming-convention to correctly handle booleans.

AndreaPontrandolfo / sheriff

A comprehensive and opinionated Typescript-first ESLint configuration.

https://www.eslint-config-sheriff.dev

MIT License

106 stars 7 forks source link

Update ts-eslint/naming-convention to correctly handle booleans. #131

Closed bezi closed 7 months ago

bezi commented 7 months ago

In the base rule documentation, it is documented that PascalCase should be used in order to correctly use names like isLocked or hasAppropriateAccess, as the variable is stripped of its prefix verb before it is checked.

This PR fixes that.

changeset-bot[bot] commented 7 months ago

🦋 Changeset detected

Latest commit: 043c53d0f709e79970517e04a774956989afef76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------------------- | ----- | | eslint-config-sheriff | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sheriff	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 3, 2024 10:03pm

AndreaPontrandolfo commented 7 months ago

Hey @bezi !

Super-great catch! BUT, i tested this and as-is, this still doesn't work correctly. In order for this to work, we also need to remove 'boolean' from the second object. I'll update the PR and merge this!

Also i'll add the changeset