AndreaPontrandolfo / sheriff

A comprehensive and opinionated Typescript-first ESLint configuration.
https://www.eslint-config-sheriff.dev
MIT License
101 stars 6 forks source link

Fix typos #156

Closed lishaduck closed 2 weeks ago

lishaduck commented 2 weeks ago

Unfortunately, one leaked into the public api, necessitating a major.

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 1859c47143b42d4372d3a374c3214c0d4829692e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | --------------------- | ----- | | eslint-config-sheriff | Major | | @sherifforg/types | Major | | docs-website | Patch | | sheriff-webservices | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sheriff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 4:25pm
lishaduck commented 2 weeks ago

Docusaurus claims I broke a link, but I'm 99% sure it's wrong.

lishaduck commented 2 weeks ago

Oh, nope, it's right. 😅 I'll fix it! 🙃

AndreaPontrandolfo commented 2 weeks ago

Oh gosh, i have no idea how this did slip trough haha

lishaduck commented 2 weeks ago

Oh gosh, i have no idea how this did slip trough haha

It's been like this the whole time, but I never got around to complaining 😆

AndreaPontrandolfo commented 2 weeks ago

I had Megalinter setup on CI but i had to disable it because it was too much noise.

lishaduck commented 2 weeks ago

I had Megalinter setup on CI but i had to disable it because it was too much noise.

Yeah. I've found running streetsidesoftware/cspell-action to be good at catching it instead, as I couldn't get megalinter to play nice with my ESLint config.

AndreaPontrandolfo commented 2 weeks ago

Yeah Cspell is integrated into Megalinter. But again, it was too much work to keep up with.

I couldn't get megalinter to play nice with my ESLint config.

I simply disabled the Eslint part of Megalinter, as obviously i didn't need it.

lishaduck commented 2 weeks ago

Oh, and I guess once we get typescript-eslint@8, then we could remove pathsOverrides in favor of using the projectService.

AndreaPontrandolfo commented 2 weeks ago

Oh, and I guess once we get typescript-eslint@8, then we could remove pathsOverrides in favor of using the projectService.

What do you mean?

lishaduck commented 2 weeks ago

Oh, and I guess once we get typescript-eslint@8, then we could remove pathsOverrides in favor of using the projectService.

What do you mean?

https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta/#project-service

AndreaPontrandolfo commented 2 weeks ago

Oh, and I guess once we get typescript-eslint@8, then we could remove pathsOverrides in favor of using the projectService.

What do you mean?

https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta/#project-service

I'll start a discussion so we can merge this in the meantime.

AndreaPontrandolfo commented 2 weeks ago

Discussion started here: https://github.com/AndreaPontrandolfo/sheriff/discussions/160