AndreaPontrandolfo / sheriff

A comprehensive and opinionated Typescript-first ESLint configuration.
https://www.eslint-config-sheriff.dev
MIT License
106 stars 7 forks source link

Make Astro Optional #157

Closed lishaduck closed 2 months ago

lishaduck commented 2 months ago

Closes: #153 Closes: #130

Put Astro behind an option.

Tests

It works in my vanilla-TS Bun monorepo; is there a good Astro project I can test it on?

Originally posted by @lishaduck in https://github.com/AndreaPontrandolfo/sheriff/issues/153#issuecomment-2218249341

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: d308d566f5641c548e6735ecb05c93032e4eb97c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages | Name | Type | | --------------------- | ----- | | eslint-config-sheriff | Major | | @sherifforg/constants | Patch | | @sherifforg/types | Patch | | docs-website | Patch | | sheriff-webservices | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sheriff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2024 11:40am
lishaduck commented 2 months ago

Oh, and if this does work, then I'll need to update the docs.

AndreaPontrandolfo commented 2 months ago

Yup, can you update the docs?

lishaduck commented 2 months ago

Oops.