search

AndreaPontrandolfo / sheriff

A comprehensive and opinionated Typescript-first ESLint configuration.
https://www.eslint-config-sheriff.dev
MIT License
106 stars 7 forks source link

[Proposal] Replacing eslint-plugin-react with eslint-react #189

Closed Talent30 closed 2 months ago

Talent30 commented 2 months ago

eslint-react is a modern version of eslint-plugin-react https://eslint-react.xyz/docs/faq https://github.com/Rel1cx/eslint-react/issues/85

I will send a PR shortly if @AndreaPontrandolfo likes this idea.

AndreaPontrandolfo commented 2 months ago

Hey @Talent30 !

Sheriff is already using @eslint-react/eslint-plugin, but just for a couple of rules that i find useful and are not covered by eslint-plugin-react. That being said, at this stage i don't consider @eslint-react/eslint-plugin a replacement for eslint-plugin-react. It's a very interesting project but it is still young and is still growing, it will take a while to reach the level of maturity of a project like eslint-plugin-react.

In summary, Sheriff is already employing @eslint-react/eslint-plugin so no PR is needed, thank you anyway for the report. I'm gonna close this now.

lishaduck commented 2 months ago

@AndreaPontrandolfo, maybe move this to a discussion? I think that at some point, it'd be nice to swap over to @eslint-react, but stick with both for now, given that it's a maturity/compatibility issue. Just my 2¢.

AndreaPontrandolfo commented 2 months ago

So, one of the issues with this, is that @eslint-react/eslint-plugin isn't a drop-in replacement for eslint-plugin-react, as outlined here. So transitioning wouldn't be trivial, and it's questionable whether it would be an objective improvement or not.

lishaduck commented 2 months ago

So, one of the issues with this, is that @eslint-react/eslint-plugin isn't a drop-in replacement for eslint-plugin-react, as outlined here. So transitioning wouldn't be trivial.

Yeah, so maybe wait for v30? (Maybe make majors that're multiples of majorly major? I personally like RedwoodJS's Epochs concept.)

It's questionable whether it would be an objective improvement or not.

Maybe not yet, but at some point it will likely mature, and then it's a more flexible, feature-complete, and more maintained plugin.

Anyway, I still vote this becomes an "ideas" discussion.