search

AndreaPontrandolfo / sheriff

A comprehensive and opinionated Typescript-first ESLint configuration.
https://www.eslint-config-sheriff.dev
MIT License
104 stars 7 forks source link

[REPLACE] `eslint-plugin-import` → `eslint-plugin-import-x` #200

Open lishaduck opened 1 month ago

lishaduck commented 1 month ago

Neither one supports ESLint 9. However, eslint-plugin-import-x is (subjectively) easier, (objectively) lighter weight, and (likely) faster. I propose migrating, slapping a fixupPluginRules on it, and praying it works.

AndreaPontrandolfo commented 3 weeks ago

Heh, i'm kind of conflicted on this one. After the work done in https://github.com/AndreaPontrandolfo/sheriff/pull/208 and https://github.com/AndreaPontrandolfo/sheriff/pull/219, all of our 7 eslint-plugin-import rules are now working correctly in ESLint v9. I'm not exactly sure what tangible value eslint-plugin-import-x would provide for us right now.

I'll leave this issue up, so we track the progress of eslint-plugin-import-x and if it really get substantially ahead of eslint-plugin-import in some significative way, we'll make the switch.

lishaduck commented 3 weeks ago

Oh, import-x merged ESLint 9/TSESLint 8 compat (not yet released though). We don't need to fix what ain't broke, but just an fyi.