AndreaUnlimited / starfriends

15 stars 0 forks source link

make tags save automatically without having to click "save tags" #60

Open fallerOfFalls opened 8 years ago

fallax commented 8 years ago

I think this is pretty important - especially since the editing tags on the All Tags page doesn't need you to press save.

We should probably still either have a placebo save button, or a message that indicates that the changes have been saved successfully, otherwise people will be wondering if it has been saved or not.

fallerOfFalls commented 8 years ago

Or a save button with "save changes" on it, that switches to "changes saved" once the latest data has been uploaded.

Cassolotl commented 7 years ago

If we have this, we need to resolve backspace clears all tags!

Cassolotl commented 7 years ago

This is not possible; the server can't handle the demand this would place on match calculations. Sorry! :S

fallerOfFalls commented 7 years ago

Can it not auto-save whenever you leave the page?

Cassolotl commented 7 years ago

I talked to Andréa, and she said that she could have a pop-up appear to warn you if you've made changes and not saved. We're definitely not having an autosave though.

It would also help us to know why we want the tags to autosave. Is it because you're forgetting to save your tags after editing? Or something else maybe?

fallerOfFalls commented 7 years ago

Because modern websites do that (and therefore it is expected behaviour, and not doing that means users will often lose their data by accident), and it's a feature that makes sense. Are users more likely to be sad that their stuff wasn't saved? or happy that it wasn't saved? If you edit something, why would you want it to scrap your edits it by default? If some users want to be able to not save their changes, add a "reset to what I had before" button.

Cassolotl commented 7 years ago

@fallerOfFalls I think then that in order to avoid people assuming their tags have been saved we can do the "you've not saved your tags, are you sure you want to leave this page?" pop-up, and put the save button in a better place perhaps?

If you edit something, why would you want it to scrap your edits it by default?

I think it's kind of partly down to what we're used to. Because I know that my tags won't automatically be saved, I feel better that if I make a mistake (like with the problem where holding down the delete key deletes ALL your tags) I can just close or reload the tab and everything will stay the way it should be. If I was expecting my tags to be saved automatically I would probably edit more carefully. But I expect the Save button to be there and for the form to not save until I click that button, so it works fine for me. At least while we're in alpha and the design is not final, it might be that members will just have to get used to it not saving tags. It might always have to be this way. But I have spoken to Andréa about moving the Save button to a more obvious place, and about the pop-up thing, so hopefully she can do something like that and it will help.

it's a feature that makes sense.

Unfortunately we can't really consider that, because each time a tag is saved the system has to do a whole bunch of calculations. It's just not possible to save and recalculate every time a tag is added or removed.

AndreaUnlimited commented 7 years ago

Thank you for your help @fallerOfFalls !

Everything that @Cassolotl said, plus: currently there is no way to automatically save tags without completely redesigning the page and way it's handled, so even though I'm starting to see that it is needed, I won't do it until I have enough time to do the entire page, which is going to be a lot of work! Thank you for your patience!

Cassolotl commented 7 years ago

I will wiggle the tags accordingly. :) Thanks @AndreaUnlimited !