added datetime offset - Githubissues

Andreas-Dorfer / base-types

Fight primitive obsession and create expressive domain models with source generators.

MIT License

18 stars 2 forks source link

Closed jeffward01 closed 1 year ago

jeffward01 commented 1 year ago

Added DateTimeOffset

Note:

I accidently hit 'Resharper Cleanup' and I believe it changed some of your styling to add the brackets { } on your IF statements where you have no brackets. There is no .editorconfig so my resharper did not pick this up.

By Resharper - i mean Jetbrains Rider IDE because its definitely the best experience compared to VS in my opinion.

Let me know if any questions or issues with this PR

Thanks

Andreas-Dorfer commented 1 year ago

Thanks for the PR! DateTimeOffset is definitely useful.

Can you please remove the rider-specific .idea folder and the sln.DotSettings file? If you want, you can add a rule to .gitignore.

jeffward01 commented 1 year ago

@Andreas-Dorfer - no problem!

Done! should be removed (I also added them to .gitignore)

Andreas-Dorfer commented 1 year ago

@jeffward01 based on a quick search, sln.DotSettings looks like a ReSharper specific file. So, it should be alright to remove it.