search

AndreasAugustin / go-gitmoji-cli

:octocat: A conventional gitmoji commit interactive command line tool for using emojis on conventional commits. :rocket:
https://gitmoji.dev/
MIT License
8 stars 0 forks source link

[Bug]: creating release with release please action does not trigger goreleaser action #47

Closed AndreasAugustin closed 1 year ago

AndreasAugustin commented 1 year ago

Is there an existing issue for this?

Describe the bug

Currently release please is used to create releases. With new release goreleaser is used to deploy the go artifacts.

When manually creating a release this will trigger the goreleaser action but when the release is done with release please, the action is not triggered

Expected Behavior

when the release is created the goreleaser action should be triggered.

Current Behavior

the goreleaser action is not triggered

Steps To Reproduce

No response

Possible Solution

No response

Additional Information/Context

No response

go-gitmoji-cli Version

v0.2.7-alpha

AndreasAugustin commented 1 year ago

There is a link with same issue: https://github.com/googleapis/release-please/issues/766

Related to docs: https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs.

So will change it with if: ${{ steps.release.outputs.release_created }} in one single action.