search

AndreasMadsen / trace

Creates super long stack traces
https://trace.js.org
MIT License
194 stars 18 forks source link

tracing core module and node 0.11.15 #12

Closed mpal9000 closed 9 years ago

mpal9000 commented 9 years ago

Hi, the "tracing" core module has been removed from node v0.11.15

AndreasMadsen commented 9 years ago

Oh, yeah, that was supposed to happen eventually. @trevnorris what is the recommended alternative to the tracing module?

trevnorris commented 9 years ago

Nothing right now. Currently there is an undocumented way to tap into AsyncWrap's internal mechanism, and left that way to module developers can experiment with the API so we can get feedback while figuring out the best API to use.

AndreasMadsen commented 9 years ago

@trevnorris Thanks for clarifying, I will try migrating to that API.

AndreasMadsen commented 9 years ago

@mpal9000 I'm working on it. But unfortunately there is a few bugs in the new AsyncWrap interface. So for now you will have to stick to node 0.11.14.

mpal9000 commented 9 years ago

All right, thank you!

AndreasMadsen commented 9 years ago

@mpal9000 node 0.11.15, 0.11.16 and iojs should now be supported. However it uses some really dirty hacks so I can't promise anything, but we will just have to take those issues as they appear. Node 0.11.14 is still supported using the old approach, so you can downgrade to that if you hit any major issues.

EDIT: there is also some performance hit. The benchmark went from 7x slower to 11x slower than the baseline (without trace). However with the recent upgrade to stack-chain 1.3.1 it pretty much cancels out.

mpal9000 commented 9 years ago

I'll let you know if I have any issues, thanks!