search

AndreasMadsen / trace

Creates super long stack traces
https://trace.js.org
MIT License
194 stars 18 forks source link

[test] Ignore stack lines from outside our test code #51

Closed cspotcode closed 5 years ago

cspotcode commented 5 years ago

Splitting #40 into multiple PRs for easier review.

This stops the tests from breaking with Node.js updates.

AndreasMadsen commented 5 years ago

This makes the test too relaxed. It was this way a long time ago, but there are some bugs related to removing lines that this won't test for.

cspotcode commented 5 years ago

Ok, would you like a PR that fixes failing tests by updating them for node v11, the version being used by the TravisCI tests?

AndreasMadsen commented 5 years ago

Sure, we can do that. I don't care that much about a green TravisCI myself. I just use git diff as a sanity check that things are good.