Closed AndreasSko closed 2 years ago
Currently, the heuristic to decide if we need to migrate locations from the regular bible translation to the study one simply checks if the majority on one side has already been migrated (see https://github.com/AndreasSko/go-jwlm/blob/66622c88f54b317dbbf885c13b4ce643398ad77b/merger/LocationMerger.go#L110). This can be unreliable as reported in https://github.com/AndreasSko/go-jwlm/issues/97. It would be better to check for collisions of the same userMarkGUID or NoteGUID to determine if one side has been upgraded.
Currently, the heuristic to decide if we need to migrate locations from the regular bible translation to the study one simply checks if the majority on one side has already been migrated (see https://github.com/AndreasSko/go-jwlm/blob/66622c88f54b317dbbf885c13b4ce643398ad77b/merger/LocationMerger.go#L110). This can be unreliable as reported in https://github.com/AndreasSko/go-jwlm/issues/97. It would be better to check for collisions of the same userMarkGUID or NoteGUID to determine if one side has been upgraded.