search

AndreasSko / go-jwlm

A command line tool to easily merge JW Library backups, written in Go.
MIT License
71 stars 4 forks source link

Minor bug with merged export #97

Closed aui01 closed 2 years ago

aui01 commented 3 years ago

78F760FE-DE3D-43FD-BD6E-7C70AD9F6E33 Hi Andreas,

looks like I found a minor bug while trying to export a merged file. Actually I’m not really understanding the error message…do you have an idea? Hast ne Idee?

Best regards, Alex

AndreasSko commented 3 years ago

Hi Alex, thank you for your report! Ouh, that's a weird one. It looks like it "merged" the same marking twice, resulting in a duplicate which prevents the exporting. That is definitely a bug and should not happen.. A few questions that come to my mind: Is that the first time you merge those two backups or did you already do that for previous versions and it worked fine? If the latter, are you able to somehow pin it to a specific marking that you added? Does the problem also occur if you choose "left" for the conflict autoresolution ("Automatische Konfliktlösung") of markings? I guess the easiest for me to debug would be to have those two backup files and see if I find a weird edge case. If you like, you could send the backups to me via email at jwlm@andreas-sk.de. Of course, I would only look at those two markings. But I can fully understand if you would rather not do that - that's not a problem at all! :slightly_smiling_face:

Thanks again for your message, I really appreciate it!

AndreasSko commented 3 years ago

(Transferred issue to go-jwlm as it's a bug of the merge logic itself)

AndreasSko commented 2 years ago

@aui01 Thank you again for your help! I uploaded the latest beta to TestFlight which should fix the issue. If you like, you can download it here: https://testflight.apple.com/join/lMl8Gsc2. If testing looks good, I will publish it to the App Store in a few days :slightly_smiling_face:

aui01 commented 2 years ago

@AndreasSko Thanks for the update.Sorry to say it still doesn't work in my case, see screenshot below.image

AndreasSko commented 2 years ago

Ouh.. Yeah I guess you discovered another edge-case that I haven't thought about yet 🙈 I will work to include that in the final fix too. Sorry for that 😅

AndreasSko commented 2 years ago

@aui01 I pushed another update to TestFlight, which should hopefully fix all issues this time. You had two more very interesting edge-cases regarding the migration from the normal edition to the study edition of the New World Translation, which took a bit more time to figure out, fix and verify :slightly_smiling_face: If it looks good, I would polish the change a bit more and finally publish it to the App Store.

aui01 commented 2 years ago

Hi Andreas, tried it a minute ago and it works great now. No more edge-cases with me now.

Thank you! Alex