search

AndreiCalazans / rn-tooltip

A <Tooltip /> component for React Native
MIT License
323 stars 75 forks source link

74: fixes Android container's bottom position #75

Closed ChristinaKrapivina closed 2 years ago

ChristinaKrapivina commented 3 years ago

Reference Issues

Android issue padding between pointer and container 74. Link

Fix explanation

Dimensions.get('window').height returns wrong height on Android. Here is an open react native issue.

I've modified screenHeight calculations depending on the system, and the status bar height.

ChristinaKrapivina commented 3 years ago

@AndreiCalazans It would be awesome, if you could take a look at this fix. It resolves the issue, that people were sharing.

ChristinaKrapivina commented 3 years ago

@AndreiCalazans Good day. Could you have a look at the fix and let me know if it's okay? This issue is very important for our prod.

Bohda-P commented 3 years ago

Hi @AndreiCalazans!!! Please take a look on this PR. It will fix a lot of troubles with rendering of the component.

LeLuyen commented 3 years ago

Hi All,

Not working on Xiaomi K20pro

jensdev commented 2 years ago 
export const ActualScreenHeight = Platform.select({
  ios: ScreenHeight,
  android: ScreenHeight - StatusBar.currentHeight,
});

Works on all devices I've tested so far

jensdev commented 2 years ago

I also had issues when using different fontscaling on my device. I made a seperate PR https://github.com/AndreiCalazans/rn-tooltip/pull/84

AndreiCalazans commented 2 years ago

Favored PR 84 https://github.com/AndreiCalazans/rn-tooltip/pull/84/files