search

AndreiDrang / python3-anticaptcha

Python library for AntiCaptcha.
https://andreidrang.github.io/python3-anticaptcha/
MIT License
157 stars 39 forks source link

Don't use tight requirements #66

Closed hsnprsd closed 3 years ago

hsnprsd commented 3 years ago

Hey. As you may know python's new package dependency resolver is going to change and be strict about conflicting package dependencies. The current requirements are too strict and I don't think they are needed.

AndreiDrang commented 3 years ago

Hi!

As you may know python's new package dependency resolver

Nope, I don't know. Can u give more info?

hsnprsd commented 3 years ago

You can see the documentation here: https://pip.pypa.io/en/latest/user_guide/#changes-to-the-pip-dependency-resolver-in-20-3-2020

hatarist commented 3 years ago

Anyway, the strict version pinning has led to a problem where you can't upgrade the aiohttp from 3.7.2 to 3.7.3 because this module explicitly asks for 3.7.2 (in setup.py).

Anyway, it's a good practice to use >= and <= instead of just using the certain version ==. Which minimum version of the aiohttp does python3-anticaptcha really need?

(so we could change it to, say, aiohttp>=3.0.0 to get broader coverage of compatible envrionments)

AndreiDrang commented 3 years ago

Check pls https://github.com/AndreiDrang/python3-anticaptcha/pull/68