STreeDescriptor display issues (2)

[osm0sis]

Following your example JSON I've encountered a couple bugs I wanted to report in case you hadn't noticed them yet. The first pic is for scheduler but I've seen it with governor (so your example code) as well.

1) Sometimes this error occurs, but simply closing and reopening Synapse resolves it:

2) Switching from one option to another can result in duplicated or triplicated tunables being listed. Switching to another and back again once more (or so) seems to resolve this display issue:

[AndreiLux]

Seems like a race-condition. I can't reproduce it, if you can then please report exact steps.

[osm0sis]

1) Happens randomly. No exact steps, it's just there on some starts of Synapse and closing the app and reopening resolves it.

2) I change governors (or schedulers) until it happens. It doesn't happen every time. Usually by the second or third change it'll happen. Then second or third change again it'll display normally again.

[anarkia1976]

Even my side I noticed the same thing. Just make a switch between the default governor and another to see it. I'm sorry but I do not know how to collect the logs.

[AndreiLux]

Closing due to failing to reproduce and seemingly no further reports.

[osm0sis]

I can still reproduce the governor tunable triplication extremely easily. I just tried getting a logcat for you but it doesn't seem to produce any error.

[anarkia1976]

The problem persist also for me .... you can reproduce it the same way described by @osm0sis, changing the governor or the scheduler (code: https://github.com/anarkia1976/N4UKM/blob/master/data/UKM/config.json.generate.cpugov -> code related to CPU Governor Tunables).

[osm0sis]

And mine, which is almost exactly the same as Andrei's example code: https://github.com/bsmitty83/DirtyV_tuna/blob/DirtyV-f2fs/ramdisk-DirtyV/res/synapse/config.json.generate.governor

[AndreiLux]

I'm still unable to reproduce it. Just exactly how often does this happen?

[osm0sis]

My device boots up with interactive as the default governor and that displays correctly. Changing it from interactive to ondemand it almost always happens the first time I try.

[AndreiLux]

I went on to recompile a kernel with new governors to reproduce this. I'll look into it.

[AndreiLux]

https://www.dropbox.com/s/aap9rjr15witpgg/Synapse.apk

Please try the above to see if the problem reoccurs, and especially check if everything else is behaving normally with the TreeDescriptor.

[osm0sis]

So far so good here. I switched interactive -> ondemand -> conservative -> ondemandplus a few times and haven't been able to reproduce the issue yet. :+1:

Only thing I notice, and could be from before, is that the tunables aren't alphabetical. What logic defines the order? There must be some since I notice the row scheduler order matches the old one @franciscofranco used in franco.Kernel updater, even though it's also not alphabetical. It's pretty much a non-issue, just curious (though the option to choose sorting method would be pretty cool).

[AndreiLux]

Just the way that File.listFiles() returns the filenames, which is haphazard.

There is no guarantee that the name strings in the resulting array will appear in any specific order; they are not, in particular, guaranteed to appear in alphabetical order.

[anarkia1976]

all ok now @ AndreiLux, I confirm: everything works perfectly. :) thanks a lot.

[osm0sis]

Fantastic! If I ever see (1) again I'll post a log, since as an error it should show. Thanks.