AndreiUlmeyda / oil

Search-as-you-type cli frontend for the buku bookmarks manager using peco.
GNU General Public License v3.0
147 stars 7 forks source link

Support for non FHS distros such as NixOS #27

Open AtilaSaraiva opened 2 years ago

AtilaSaraiva commented 2 years ago

Hello, I'm in the process of packaging oil into NixOS but there is one glaring problem. It searches the files from the $LIBDIR directory which currently is located on /usr/local/... which is not present on NixOS. I'd like to propose using the normal way of getting files from the PATH or LD_LIBRARY_PATH, or something like that, so it would be easier. If it ain't possible I might have to patch your code on my side.

Thx for your amazing app.

AndreiUlmeyda commented 2 years ago

Hey there, thanks for the suggestion. I will be glad to help with that. Not today but perhaps over the course of the next week or two. I'm not well informed about the proper ways to configure library paths. I've you've got resources to learn about that and a suggestion about how to do this in a way which works with NixOS and nonNixOs I would be thankful. Cheers

AndreiUlmeyda commented 2 years ago

Wait, theres a PR alreay. Even better ;). I will look into it and probably test it inside a vm. Thanks a lot.

AtilaSaraiva commented 2 years ago

You're welcome! Yeah, I patched the LIBDIR variable with the correct one for NixOS. It took some time for me to figure out but the PR is already merged

AtilaSaraiva commented 2 years ago

In fact, the package is already available in the unstable channel:

https://search.nixos.org/packages?channel=unstable&show=[oil-buku](https://search.nixos.org/packages?channel=unstable&show=oil-buku&from=0&size=50&sort=relevance&type=packages&query=oil-buku)&from=0&size=50&sort=relevance&type=packages&query=oil-buku

I'm working into backporting it!