AndrejOrsula / pymoveit2

Basic Python interface for MoveIt 2 built on top of ROS 2 actions and services
BSD 3-Clause "New" or "Revised" License
137 stars 54 forks source link

Add Kinova JACO + MICO definitions to robot #32

Closed egordon closed 1 year ago

egordon commented 1 year ago

Matching the style of the panda arm and the MoveIt definitions from the kinova-ros repo.

Please lmk if you have specific PR procedures to follow. We will have future PRs that address a few of the following issues:

egordon commented 1 year ago

Thank you so much for giving this a look, this was partially a simpler PR to ask for your preferred procedures before asking for reviews of beefier code changes. Please let me know if there is anything I can do in the PR (e.g. a template) to make things easier on your end.

AndrejOrsula commented 1 year ago

This is great. Thanks again!

Just one more thing: Could you please run it through pre-commit for consistent formatting? There is a helper script within the repository here, or using the commands below. Thank you.

# Install via pip
pip install --user pre-commit
# Run pre-commit hooks (`--all` to consider all/unchanged files)
pre-commit run --all
egordon commented 1 year ago

@AndrejOrsula done!

AndrejOrsula commented 1 year ago

Great. Thank you for your contribution!