Andreone
commented
13 years ago Hi,
I will not debate on the code itself. I never coded with php before and I just tinkered something. Obviously you know php better than me.
However, there are few changes I'm not comfortable with:
- you added the jar file into the project. But it was intentional from me to not distribute it. The jar file can already be installed somewhere because it can be used outside dokuwiki. For example, I use it with doxygen to document some code at my job. I don't want to have two versions of plantuml on the same system. Also, the plantuml project is active and frequently updated with new features and bug fixes, I don't want to distribute an outdated file nor update the plugin each time plantuml is updated.
- you used
and . If I recall correctly, this tags are already used by an other plugin (can't remember which one though) - you removed the ability to choose the icon. I agree this was not a great feature but it was pretty harmless.
whiskeysierra
added -Djava.awt.headless=true to the exec call