search

Andreone / dokuwiki_plantuml

A plugin for Dokuwiki that generates UML graphs from text using PlantUML
http://www.dokuwiki.org/plugin:plantuml
13 stars 20 forks source link

Directory name problem #10

Closed elmendavies closed 13 years ago

elmendavies commented 13 years ago

The capital letters in the plugin's name directory are not supported by dokuwiki (Maybe we should fix dokuwiki instead!!).

Solution (suggestion only): In plugin.info.txt replace the line: base PlantUML with: base plantuml

Andreone commented 13 years ago

Hi,

I don't see the relation between the plugin's directory name and the base field of the plugin.info.txt file. Could you give me more information? What are the symptoms?

Thank you

elmendavies commented 13 years ago

Dear Andreone, I had a discussion with M. Schulte last days. See: https://bugs.dokuwiki.org/index.php?do=details&task_id=2204#comment3639

Btw.: https://www.dokuwiki.org/devel:plugins#plugin_name -> "A valid plugin name should only contain the characters a-z and 0-9"

The problem is that some components of dokuwiki doesn't recognize capital letters and doesn't load.

"base" field in plugin.info.txt should have no capital letters.

I would suggest to change it to base plantuml which is the best to meet the standard naming conventions.

Thank you

elmendavies commented 13 years ago

He mentions an alternative solution that teorically should work, changing this line:

$this->Lexer->addSpecialPattern('<uml.?>\n.?\n', $mode, 'plugin_plantuml);

to:

$this->Lexer->addSpecialPattern('<uml.?>\n.?\n', $mode, 'plugin_PlantUML');

Of course this second alternative does not meet naming conventions.

Andreone commented 13 years ago

It's fixed now. I've lowercase the name in plugin.infot.txt Thanks.