search

AndresMorelos / Invoncify

🎉 Flexible invoicing desktop app with beautiful & customizable templates.
GNU Lesser General Public License v3.0
79 stars 14 forks source link

[BUG]: Payment date error: 'Invalid Date' when editing another day than creating #81

Closed Tech6767 closed 2 years ago

Tech6767 commented 2 years ago

Describe the bug Small thing I just noticed: When creating an invoice on day one and it is getting edited on day 2, if there was a payment date set to 10 days (probably others as well) it will show an error.

This happened, when I created an invoice at like 23:50 and edited it at 0:05 in the night. Suddenly the payment date was broken.

The creation date is the date of editing, which is fine (and correct), but I guess it is the source of the bug.

To Reproduce Steps to reproduce the behavior:

  1. Create an invoice
  2. set payment date to 10 days
  3. edit the invoice a day later
  4. See error

Expected behavior The date should be recalculated for the new creation date of the invoice. example: First creation date: 4. June 22 payment date: 14. June 22 edited creation date: 5. June 22 payment date: 15. June 22 Screenshots

image

Desktop (please complete the following information):

AndresMorelos commented 2 years ago

@Tech6767 could you please share with me the invoncify version? I'm not able to reproduce it in the latest version.

Tech6767 commented 2 years ago

I am using the Invoncify-1.17.1.AppImage from Github. @AndresMorelos

AndresMorelos commented 2 years ago

@Tech6767, still not getting this issue, either with that version of Invoncify or later, I didn't test on your specific OS, so let me verify If I can make a VM with that OS and test it.

Tech6767 commented 2 years ago

@AndresMorelos I will try again. I opened another invoice and will edit it tomorrow. If it does not happen again, I will close the issue. Thanks for trying.

AndresMorelos commented 2 years ago

@Tech6767, did you reproduce the issue?

Tech6767 commented 2 years ago

@AndresMorelos I forgot about it...tried it now and yes, it still occurs: image

Maybe it needs to be in german? I entered more text in the payment details field, that's how it changes the creation date and then it messes up the 10 days due date.

Tech6767 commented 2 years ago

I can update the app and see if it still occurs?

AndresMorelos commented 2 years ago

@Tech6767 yes, you can update the app, there is not problem.

I will setup your OS on a VM in order to test it.

AndresMorelos commented 2 years ago

@Tech6767 I was able to reproduce the issue but without changing the Creation date, just selecting another due date term.

I'm working on this Right, the new versión of the app will be released soon with the fix. stay tunned.

AndresMorelos commented 2 years ago

@Tech6767 Issue fix at v1.9.1, If the issue persists for you please reopen the issue and attach a video with your steps, the only way that I was able to reproduce it was without updating the creation date.