search

Andrettin / Wyrmsun

Strategy game based on history, mythology and fiction
http://andrettin.github.io/
GNU General Public License v2.0
301 stars 47 forks source link

Bug in techtree #159

Closed BeWorld2018 closed 6 years ago

BeWorld2018 commented 6 years ago

No button to return to menu.

LONGACAT commented 6 years ago

The button exists in 3.3.0, what is your version?

BeWorld2018 commented 6 years ago

After check, it's my translate file.. sorry

So i modify a lot of file (.lua) in script to have more translatable strings. It's possible to put in this repository ?

BeWorld2018 commented 6 years ago

i find bug in menu/techtree.lua

delete _() here

if (playable_civilization_species ~= playable_civilization) then table.insert(civilization_list, playable_civilization_species .. " - " .. playable_civilization) else table.insert(civilization_list, playable_civilization) end

Andrettin commented 6 years ago

Yup, I am just finishing fixing the bug, having seen the issue earlier on :)

It's not as simple as just removing the _( and ) there though, since that prevents those strings from being translatable; a better solution is to have both a list with the display strings and one with the idents that are used to get data about the civ.

Andrettin commented 6 years ago

Fixed now! About making more strings translatable, you could create a pull request with that, or just attach the files here.

In any case, note that some strings (i.e. unit names in unit definitions) shouldn't be set as translatable directly. In those cases it is better to make the UI uses of those strings translatable instead.