search

Andrew-Chen-Wang / RichEditorView

Rich Text Editor in Swift. Newly Featured Code and Swift 5 compatible of cjwirth/RichEditorView.
BSD 3-Clause "New" or "Revised" License
136 stars 59 forks source link

Adding your RichEditorView group has issues building #9

Closed brandtdaniels closed 3 years ago

brandtdaniels commented 4 years ago

In RichEditorOptionItem Line 162: Value of type 'RichEditorView' has no member 'checkbox'

In RichEditorView Line 358: Use of unresolved identifier 'offline' Line 360: Use of unresolved identifier 'vidURL' Line 400: Expression of type 'String' is unused Line 406: Invalid redeclaration of 'addRowToTable()'

YoomamaFTW commented 4 years ago

Interesting. I did this mostly through an SSH terminal into my work computer at the time. Planning on reworking it on Xcode IDE itself sometimes next month.

maqiqing commented 4 years ago

same problem..how to fix it?

YoomamaFTW commented 4 years ago

@maqiqing This is mostly due to missing code in the JS or undeclared variables. Looking to fix this this month hopefully!

shillwil commented 4 years ago

Cmd+A and Ctrl+i in RichEditorView fixes most of these issues. For some reason, text formatting in the code file causes anywhere from 5-20 build errors.

Kedar-27 commented 4 years ago

@maqiqing This is mostly due to missing code in the JS or undeclared variables. Looking to fix this this month hopefuly!

Please fix this asap. Critical issue.

YoomamaFTW commented 3 years ago

It has been fixed. I'm hopefully going to publish this package on to SPM. Edit: Or well not me but the new maintainer. Sorry for the long wait.

Andrew-Chen-Wang commented 3 years ago

Please let me know if there are any more issues. I'll be taking over maintainership for the time being and adding this to SPM. Hopefully I can make this package more extensible regarding the styling as well. Extending the JS can also be done via runJS but people might want to just include an entirely new file, which I can understand, so I'll be looking to do that as well.

Andrew-Chen-Wang commented 3 years ago

I've created an iOS example app and fixed some bugs. It'll be a slightly slow process in fixing everything since I'm pretty busy with school, but at least y'all can use this somewhat now. Thanks for the patience!