Closed ruediste closed 1 year ago
Oh wow, thanks for the contribution. This is a lot of work. It may take me a bit to review this but I'm absolutely open to making the switch to TS
Great, nice to hear. Looking forward to your feedback.
Mostly looks good! We still have some
.js
files I see, is that going to cause a problem? (I've never worked in a hybrid environment)
No, it should not cause any issues. But you don't have typing for the .js
files...
Any news on this? Waiting for me?
Apologies. I caught COVID. I will try to take a look this weekend
On Mon, Aug 14, 2023, 12:12 Ruedi Steinmann @.***> wrote:
Any news on this? Waiting for me?
— Reply to this email directly, view it on GitHub https://github.com/Andrew-Dickinson/photonic-etcher/pull/10#issuecomment-1677633505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX6K6O57GNRZY264GQDHJDXVJFALANCNFSM6AAAAAA24VPEP4 . You are receiving this because you commented.Message ID: @.***>
My Anycubic Photon had a hard time with the generated .pws file, so I wanted to add support for .photon. I had a hard time understanding the code and thought some types would greatly help.
I also dropped the checked in libraries and switched to npm packages.
Oh, and I also changed the anti-alias count from 0 to 1. UVTools had a division by zero before...
What do you think?