search

Andrew-Dickinson / photonic-etcher

Generate exposure masks for Anycubic printers from PCB Gerbers
https://andrew-dickinson.github.io/photonic-etcher
MIT License
86 stars 10 forks source link

Invert or Flip doesn't work #5

Closed BogdanTheGeek closed 2 years ago

BogdanTheGeek commented 2 years ago

I have tried both the online and offline app, on multiple computers and browsers, I can't get the invert colours or flip board to work. The preview and the output are just a solid colour. I have attached the test files. PWM_Generator.zip

I get these errors in the chrome console:

Failed to load resource: the server responded with a status of 404 ()
/site.webmanifest:1 Manifest: Line: 1, column: 1, Syntax error.
/site.webmanifest:1          Failed to load resource: the server responded with a status of 404 ()
DevTools failed to load source map: Could not load content for https://andrew-dickinson.github.io/photonic-etcher/gerber-to-svg.min.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
DevTools failed to load source map: Could not load content for https://andrew-dickinson.github.io/photonic-etcher/pcb-stackup.min.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
Andrew-Dickinson commented 2 years ago

@BogdanTheGeek I've confirmed that for the Gerber files you provided, the invert colors and flip controls result in a blank output. Thanks for the report. I'll take a look and see if I can get to the bottom of it!

BogdanTheGeek commented 2 years ago

I used kicad 6 to generate them.

On Sun, 28 Aug 2022, 00:57 Andrew Dickinson, @.***> wrote:

@BogdanTheGeek https://github.com/BogdanTheGeek I've confirmed that for the Gerber files you provided, the invert colors and flip controls result in a blank output. Thanks for the report. I'll take a look and see if I can get to the bottom of it!

— Reply to this email directly, view it on GitHub https://github.com/Andrew-Dickinson/photonic-etcher/issues/5#issuecomment-1229341131, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDKK6TTAC4KFPPNZQCSVVTV3KTMXANCNFSM57Z6TRUQ . You are receiving this because you were mentioned.Message ID: @.***>

Andrew-Dickinson commented 2 years ago

Yep I can see that in the metadata. It looks like KiCad doesn't render Gerbers in the same coordinate "location" that Eagle does, it also appears that when tracespace converts Gerbers to SVG, they don't do any transformations to standardize the coordinate locations. Tracespace does however give a viewbox which is centered on the board (the only reason we can see it at all).

I think being a bit more careful with the SVG viewbox/coordinate handling should fix this up. I've got a prototype right now that seems to fix the invert issue, at least

Andrew-Dickinson commented 2 years ago

Okay I believe with the 1.1.3 release I have addressed this issue. Please re-open this issue if you continue to experience this bug, or feel free to open another for any others that you find :)

BogdanTheGeek commented 1 year ago

Amazing, thank you!

On Sun, 28 Aug 2022, 03:39 Andrew Dickinson, @.***> wrote:

Okay I believe with the 1.1.3 release I have addressed this issue. Please re-open this issue if you continue to experience this bug, or feel free to open another for any others that you find :)

— Reply to this email directly, view it on GitHub https://github.com/Andrew-Dickinson/photonic-etcher/issues/5#issuecomment-1229361088, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDKK6XFPLNRLUM3V76N2GLV3LGNPANCNFSM57Z6TRUQ . You are receiving this because you were mentioned.Message ID: @.***>