Open Aninuscsalas opened 1 year ago
D'oh! This is almost certainly my fault for not testing Quilt Loader on every single release.
This is probably the offending line: https://github.com/Devan-Kerman/ARRP/blob/e12a601b9ef016aaacb17c03a2763ed6231612f2/src/main/java/net/devtech/arrp/mixin/LifecycledResourceManagerImplMixin.java#L37
I just assumed that Quilt would name its mod resources the same as Fabric for better compatibility, but that looks like it was a bad assumption to make.
Just to check as well, do the vertical slabs models in the Distinct Slabs embedded resource pack (Cut Sandstone, Polished Andesite, etc) work? They should be injected in a different way than my generated resources but I see warnings related to them in your logs.
Just to check as well, do the vertical slabs models in the Distinct Slabs embedded resource pack (Cut Sandstone, Polished Andesite, etc) work? They should be injected in a different way than my generated resources but I see warnings related to them in your logs.
They also don't work :/
So, is this a QFAPI bug, or is this your fault? It seems like something on QFAPI's side and you should probably report it. I don't think fixing their mistake is reasonable.
Can confirm this issue is on quilted fabrics side, as I have the issue with QFAPI as well
i've the same problem... BUT without QFAPI.... -_- if anyone have a solution...
Having the same problem using QFAPI
I recreated this problem on Minecraft 1.20.1 with Quilt 0.22 and newest QFAPI package for it.
I see the block placement information is correctly set, but problem is with resources registration. When I debug resources: rrp.debug.zip And make "resourcepack" from them: autoslab.zip
Slabs are correctly displayed..
Maybe this is kind of typehint @Andrew6rant?
Here is default with resource pack provider by mod:
Here is with added manually created resource pack on top:
When manually created resource pack is between:
When manually created resource pack is on bottom:
So there is some problem on resource pack building process or other related process
And i got an idea :)
Fabric API give us a "fabric" resource pack:
This raw MC only with fabric api.
But Quilt and it's api doesn't 🙁
@Andrew6rant maybe for quilt it's the best to load your resource on the top of everything instead of using your custom implementation of ARRP injection method?
@Andrew6rant do you have any plans / ETA for fix that behaviour?
@Andrew6rant I know it's kind of a long shot, but is there any chance of this issue getting fixed at this point? Such a shame, many mods I use are quilt-only and this is by far the best vertical slab mod.
Yeah, I haven't had much time/ motivation of late to work on Minecraft modding.
I am planning on fixing this issue (as well as a bunch of others) in the near future. I also welcome PRs.
@Andrew6rant I know it's kind of a long shot, but is there any chance of this issue getting fixed at this point? Such a shame, many mods I use are quilt-only and this is by far the best vertical slab mod.
kind of surprised that there are still quilt-only mods
Using AutoSlabs 1.1.0
With Fabric API
https://mclo.gs/we5LXDv
With Quilted Fabric API
https://mclo.gs/mhoxqm1