Andrew6rant / Auto-Slabs

Inject blockstates at runtime to automatically generate vertical slabs for every instance of SlabBlock
MIT License
26 stars 5 forks source link

[1.20.1 Quilt] Vertical Slabs don't render when using Quilted Fabric API #11

Open Aninuscsalas opened 1 year ago

Aninuscsalas commented 1 year ago

Using AutoSlabs 1.1.0

With Fabric API

https://mclo.gs/we5LXDv Screenshot from 2023-08-18 15-54-31

With Quilted Fabric API

https://mclo.gs/mhoxqm1 Screenshot from 2023-08-18 15-56-21

Andrew6rant commented 1 year ago

D'oh! This is almost certainly my fault for not testing Quilt Loader on every single release.

This is probably the offending line: https://github.com/Devan-Kerman/ARRP/blob/e12a601b9ef016aaacb17c03a2763ed6231612f2/src/main/java/net/devtech/arrp/mixin/LifecycledResourceManagerImplMixin.java#L37

I just assumed that Quilt would name its mod resources the same as Fabric for better compatibility, but that looks like it was a bad assumption to make.

Just to check as well, do the vertical slabs models in the Distinct Slabs embedded resource pack (Cut Sandstone, Polished Andesite, etc) work? They should be injected in a different way than my generated resources but I see warnings related to them in your logs.

Aninuscsalas commented 1 year ago

Just to check as well, do the vertical slabs models in the Distinct Slabs embedded resource pack (Cut Sandstone, Polished Andesite, etc) work? They should be injected in a different way than my generated resources but I see warnings related to them in your logs.

They also don't work :/ image

sylv256 commented 1 year ago

So, is this a QFAPI bug, or is this your fault? It seems like something on QFAPI's side and you should probably report it. I don't think fixing their mistake is reasonable.

DiosDonutSlave commented 1 year ago

Can confirm this issue is on quilted fabrics side, as I have the issue with QFAPI as well

corentin-godefroy commented 1 year ago

i've the same problem... BUT without QFAPI.... -_- if anyone have a solution...

Hand-Lock commented 10 months ago

Having the same problem using QFAPI

xYundy commented 10 months ago

I recreated this problem on Minecraft 1.20.1 with Quilt 0.22 and newest QFAPI package for it.

I see the block placement information is correctly set, but problem is with resources registration. When I debug resources: rrp.debug.zip And make "resourcepack" from them: autoslab.zip

Slabs are correctly displayed..

Maybe this is kind of typehint @Andrew6rant?

xYundy commented 10 months ago

Here is default with resource pack provider by mod:

Zrzut ekranu 2024-01-12 o 15 18 42 Zrzut ekranu 2024-01-12 o 15 18 57

Here is with added manually created resource pack on top:

Zrzut ekranu 2024-01-12 o 15 19 38 Zrzut ekranu 2024-01-12 o 15 19 50

When manually created resource pack is between:

Zrzut ekranu 2024-01-12 o 15 20 44 Zrzut ekranu 2024-01-12 o 15 21 09

When manually created resource pack is on bottom:

Zrzut ekranu 2024-01-12 o 15 21 58 Zrzut ekranu 2024-01-12 o 15 22 06

So there is some problem on resource pack building process or other related process

xYundy commented 10 months ago

And i got an idea :)

Fabric API give us a "fabric" resource pack:

Zrzut ekranu 2024-01-12 o 16 00 06

This raw MC only with fabric api.

But Quilt and it's api doesn't 🙁

xYundy commented 10 months ago

@Andrew6rant maybe for quilt it's the best to load your resource on the top of everything instead of using your custom implementation of ARRP injection method?

xYundy commented 9 months ago

@Andrew6rant do you have any plans / ETA for fix that behaviour?

RyanIsAinmDom commented 1 month ago

@Andrew6rant I know it's kind of a long shot, but is there any chance of this issue getting fixed at this point? Such a shame, many mods I use are quilt-only and this is by far the best vertical slab mod.

Andrew6rant commented 1 month ago

Yeah, I haven't had much time/ motivation of late to work on Minecraft modding.

I am planning on fixing this issue (as well as a bunch of others) in the near future. I also welcome PRs.

sylv256 commented 1 month ago

@Andrew6rant I know it's kind of a long shot, but is there any chance of this issue getting fixed at this point? Such a shame, many mods I use are quilt-only and this is by far the best vertical slab mod.

kind of surprised that there are still quilt-only mods