search

Andrew6rant / Auto-Slabs

Inject blockstates at runtime to automatically generate vertical slabs for every instance of SlabBlock
MIT License
26 stars 5 forks source link

Slabs from other mods are not being placed vertically #4

Closed dadoirie closed 1 year ago

dadoirie commented 1 year ago

As the title says, slabs from other mods are not being placed vertically despite those having the placement overlay which auto slabs provides. Yesterday tried with Consistency+ and for faster loading now a own instance with 2 smaller mods which provide slabs. image image

Andrew6rant commented 1 year ago

D'oh! This is a combination of two issues, one which is totally my fault, and one which is bizarre and needs significantly more research.

If your blocks look like this:

image

That is on me - my custom ARRP entrypoint doesn't inject the models late enough, the modded resources override it. That is easy enough to fix.

If your blocks do not have vertical states at all, that is a serious issue, and one that has me scratching my head. For some reason, the block registry is not being populated.

By itself, Frostbyte's Slabs and stairs works with AutoSlabs, and Consistency+ is the same. When combined, sometimes Frostbyte's slabs are not added to the registry, and sometimes C+'s slabs aren't added to the registry, and sometimes neither are added.

I have no idea why this is happening, and I don't think my mod is the cause. I will look into it further.

dadoirie commented 1 year ago

image image nope, no vertical state - screenshots show with side I've picked to place and on those slab is placed on the upper part - when placing on the other sides it places on the lower part the slab

also here I'm facing towards south image

now if facing west it's the down and right side where it places the slabs up image

Andrew6rant commented 1 year ago

I've registered a listener for blocks being added to the registry. This should solve the issue of the blockstates not being applied.

The models have been fixed with a custom event in my fork of ARRP. I'll use it internally until it gets merged into main.

dadoirie commented 1 year ago

does this mean later need to add ARRP too (when it's merged into main)?

Andrew6rant commented 1 year ago

No. I include ARRP in the jar file of my mod. But, right now I've swapped it for my ARRP fork, since the base ARRP doesn't have the functionality I need at the moment.

I'm going to wait until ARRP merges my PR before releasing an update on CurseForge and Modrinth. But for now, if you wanted to, you could download the latest version of my mod from GitHub Actions: https://github.com/Andrew6rant/Auto-Slabs/actions

It is using my ARRP instead of the official, so just ignore some of the logger spam.

dadoirie commented 1 year ago

I forgot about the actions - did build it already myself

Andrew6rant commented 1 year ago

Fixed in 1.0.1