search

Andrew6rant / Auto-Slabs

Inject blockstates at runtime to automatically generate vertical slabs for every instance of SlabBlock
MIT License
26 stars 5 forks source link

vertical glass slab texture #5

Closed dadoirie closed 1 year ago

dadoirie commented 1 year ago

that's what I meant earlier in a another issue - btw those are from Mo Glass

image image image image image image

Andrew6rant commented 1 year ago

This isn't an AutoSlabs issue, Mo' Glass handles their models in a weird way. You can fix it with a resource pack.

I might look into adding built-in support though.

dadoirie commented 1 year ago

no idea how the resourcepack should be looking - I'm just starting with a GUI resource pack - not touching blocks (for now ... and if then just adding some tweaks like shiny animation with mcmeta when a amethyst cluster is ready ... still learning)

Andrew6rant commented 1 year ago

AutoSlabs Mo' Glass texture compat

Here is a commit that adds texture and model support to Mo Glass' glass slab: https://github.com/Andrew6rant/Auto-Slabs/commit/b33cd4be9353e8f10405ac18fa79894ebb8cc778. You can see how I set up the model JSONs. I'm not going to add support for the rest of Mo Glass' blocks (not now, at least), so if you want them in the mod, feel free to make a PR.

dadoirie commented 1 year ago

thanks - will take a look

Andrew6rant commented 1 year ago

Related issue - https://github.com/Andrew6rant/Auto-Slabs/issues/12

dadoirie commented 1 year ago

sorry for that late PR #17 - tested and works ... yeah I did notice #12 and notice also sometimes randomly switching place from left to right or vice versa(and even from vertical to horizontal & vice versa, but this one is very rare) when placing a vertical slab - which ain't either a huge deal as it doesn't happen that often (but that's another issue not related with this one as it doesn't affect only glass slabs)

EDIT: feel free closing this issue once #17 is accepted