search

Andrew6rant / Auto-Slabs

Inject blockstates at runtime to automatically generate vertical slabs for every instance of SlabBlock
MIT License
26 stars 5 forks source link

Sneaking While Mining Single Slabs Causes Duplication #8

Closed Superkat32 closed 1 year ago

Superkat32 commented 1 year ago

If you sneak while mining a single slab, it drops 2 slabs instead of one. Seems to happen for all types of slabs(wooden, stone, etc.), but I haven't tested with modded slabs.

Minecraft Version: 1.20.1 AutoSlabs Version: 1.0.1

Video:

https://github.com/Andrew6rant/Auto-Slabs/assets/89557012/2d8c4484-e679-4243-81de-a8297c0a4a92

Other mods present in the video were Mod Menu and Fabric API.

Currently working on a PR to fix if you haven't fixed it locally already.

dadoirie commented 1 year ago

confirming that this happens also with modded slabs

dadoirie commented 1 year ago

What do you mean with "more duplication elsewhere" with that commit which changes the sneak? ... does this also mean no mining vertical slabs when sneaking?

Superkat32 commented 1 year ago

Whenever I tried removing that if statement, it fixed the duplication when sneaking, but then caused duplication for mining a single slab on a 2 slab block when not sneaking. That's what I've kept the if statement. Should the pull request get merged, you would still be good to mine vertical slabs, sneaking or not.

Andrew6rant commented 1 year ago

Yeah that sneaking check was to try and fix the dupe bug (meant for KleeSlabs functionality). Didn't realize it caused another dupe, haha