Andrew6rant / InventoryTabs

Adds tabs to access nearby blocks
https://www.curseforge.com/minecraft/mc-mods/inventory-tabs-updated
MIT License
40 stars 18 forks source link

Entity Inventories #2

Open 19MisterX98 opened 2 years ago

19MisterX98 commented 2 years ago

Add support for entity inventories:

Andrew6rant commented 2 years ago

After a crazy long amount of time, I've started working on this feature!

Here is Minecart inventories working:

https://user-images.githubusercontent.com/57331134/180334281-ed1c56cc-adc0-49d2-afd6-5d569acfe1d0.mp4

I still need to filter entities, right now it shows tabs for every single one (the furnace Minecart does not need a tab, for example)

EDIT: also, villager tabs:

villager tabs

sisby-folk commented 2 years ago

Just going to document the issues with this so far so they're tracked:

Each type of entity gets only one tab: (here's two famers) image

Detection method adds every entity that has a use interaction (I think?) - allays have been noted, here's an unemployed villager: image

Villager method has no context sensitivity: image

This sleeping villager wont be woken by clicking the tab (that's a completely seperate use action that needs to occur first)

Instinctively - villagers have so much additional context and settings that they're probably better implemented as a sub-type of EntityTab instead of just Simple.