Open spiralhalo opened 1 year ago
Oh my gosh, I've not gotten any notifications from this repository for some reason. Thank you very much for this PR!
I definitely need to overhaul my config system, Cloth Config is depreciated and my system for determining what is and is not worthy of a tab is janky at best.
If I find the time, I'm planning on refactoring much of my code to be cleaner, namely entity and itemstack tab support (sorry for subjecting you to that code, haha). I haven't looked much into 1.20's screen changes yet, but it seems like as good a time as ever to of it.
No problem! I mainly updated it for my own use. If it's useful, that's a bonus. If you're taking the opportunity to rework some things, that's fine by me!
Thanks @spiralhalo for your code, I did build it on my own, seems to work like a charm (in waiting an official release :) )
Hey, sorry to ping you @spiralhalo , but I was wondering if you looked at 1.20.2 ? Some mixins errors, but I'm too much of a noob to fix it by my own 🤣
Thx ;)
Crahses on 1.20.4 when opening any inventory
---- Minecraft Crash Report ----
// But it works on my machine.
Time: 2024-02-18 03:06:12
Description: Unexpected error
java.lang.BootstrapMethodError: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_494 failed
at net.minecraft.class_3929.<clinit>(class_3929.java:102)
at net.minecraft.class_634.method_17587(class_634.java:1182)
at net.minecraft.class_3944.method_17591(class_3944.java:37)
at net.minecraft.class_3944.method_11054(class_3944.java:11)
at net.minecraft.class_2600.method_11072(class_2600.java:24)
at net.minecraft.class_1255.method_18859(class_1255.java:156)
at net.minecraft.class_4093.method_18859(class_4093.java:23)
at net.minecraft.class_1255.method_16075(class_1255.java:130)
at net.minecraft.class_1255.method_5383(class_1255.java:115)
at net.minecraft.class_310.method_1523(class_310.java:1283)
at net.minecraft.class_310.method_1514(class_310.java:888)
at net.minecraft.client.main.Main.main(Main.java:265)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_494 failed
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
... 15 more
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422)
... 19 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Callback method drawBackgroundTabs(Lnet/minecraft/class_332;FIILorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V in inventorytabs.mixins.json:LoomScreenTabAdder from mod inventorytabs failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap inventorytabs-refmap.json
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468)
at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1384)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1062)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:402)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
... 22 more
A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------
-- Head --
Thread: Render thread
Stacktrace:
at net.minecraft.class_3929.<clinit>(class_3929.java:102)
at net.minecraft.class_634.method_17587(class_634.java:1182)
at net.minecraft.class_3944.method_17591(class_3944.java:37)
at net.minecraft.class_3944.method_11054(class_3944.java:11)
at net.minecraft.class_2600.method_11072(class_2600.java:24)
at net.minecraft.class_1255.method_18859(class_1255.java:156)
at net.minecraft.class_4093.method_18859(class_4093.java:23)
at net.minecraft.class_1255.method_16075(class_1255.java:130)
-- Uptime --
Details:
JVM uptime: 107.237s
Wall uptime: 96.171s
High-res time: 89.772s
Client ticks: 1617 ticks / 80.850s
Stacktrace:
at net.minecraft.class_310.method_1587(class_310.java:2564)
at net.minecraft.class_310.method_54580(class_310.java:995)
at net.minecraft.class_310.method_1514(class_310.java:911)
at net.minecraft.client.main.Main.main(Main.java:265)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
-- Affected level --
Details:
All players: 1 total; [class_746['SherlockH'/571, l='ClientLevel', x=16.67, y=64.00, z=94.49]]
Chunk stats: 4096, 609
Level dimension: minecraft:overworld
Level spawn location: World: (16,70,112), Section: (at 0,6,0 in 1,4,7; chunk contains blocks 16,-64,112 to 31,319,127), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511)
Level time: 31318083 game time, 10452051 day time
Server brand: vanilla
Server type: Non-integrated multiplayer server
Tracked entity count: 344
-- Last reload --
Details:
Reload number: 1
Reload reason: initial
Finished: Yes
Packs: vanilla, file/Ancient Debris, file/Netherrack, fabric, betterf3, caffeineconfig, cloth-config, fabric-api, fabric-api-base, fabric-api-lookup-api-v1, fabric-biome-api-v1, fabric-block-api-v1, fabric-block-view-api-v2, fabric-blockrenderlayer-v1, fabric-client-tags-api-v1, fabric-command-api-v1, fabric-command-api-v2, fabric-commands-v0, fabric-containers-v0, fabric-content-registries-v0, fabric-convention-tags-v1, fabric-crash-report-info-v1, fabric-data-attachment-api-v1, fabric-data-generation-api-v1, fabric-dimensions-v1, fabric-entity-events-v1, fabric-events-interaction-v0, fabric-events-lifecycle-v0, fabric-game-rule-api-v1, fabric-item-api-v1, fabric-item-group-api-v1, fabric-key-binding-api-v1, fabric-keybindings-v0, fabric-language-kotlin, fabric-lifecycle-events-v1, fabric-loot-api-v2, fabric-message-api-v1, fabric-mining-level-api-v1, fabric-model-loading-api-v1, fabric-models-v0, fabric-networking-api-v1, fabric-object-builder-api-v1, fabric-particles-v1, fabric-recipe-api-v1, fabric-registry-sync-v0, fabric-renderer-api-v1, fabric-renderer-indigo, fabric-renderer-registries-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-rendering-v0, fabric-rendering-v1, fabric-resource-conditions-api-v1, fabric-resource-loader-v0, fabric-screen-api-v1, fabric-screen-handler-api-v1, fabric-sound-api-v1, fabric-transfer-api-v1, fabric-transitive-access-wideners-v1, fabricloader, ias, inventoryprofilesnext, inventorytabs, itemswapper, jade, jei, jeresources, lambdynlights, libipn, lithium, malilib, minihud, modmenu, pride, reeses-sodium-options, sodium, sodium-extra, spruceui, starlight, worldedit, xaerominimap, xaeroworldmap, itemswapper:experimental_addon, itemswapper:classic, itemswapper:default
-- System Details --
Details:
Minecraft Version: 1.20.4
Minecraft Version ID: 1.20.4
Operating System: Mac OS X (x86_64) version 12.6
Java Version: 17.0.8, Microsoft
Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft
Memory: 666250304 bytes (635 MiB) / 1342177280 bytes (1280 MiB) up to 6442450944 bytes (6144 MiB)
CPUs: 12
Processor Vendor: GenuineIntel
Processor Name: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Identifier: Intel64 Family 6 Model 158 Stepping 10
Microarchitecture: Coffee Lake
Frequency (GHz): 2.60
Number of physical packages: 1
Number of physical CPUs: 6
Number of logical CPUs: 12
Graphics card #0 name: unknown
Graphics card #0 vendor: unknown
Graphics card #0 VRAM (MB): 0.00
Graphics card #0 deviceId: unknown
Graphics card #0 versionInfo: unknown
Memory slot #0 capacity (MB): 0.00
Memory slot #0 clockSpeed (GHz): 0.00
Memory slot #0 type: unknown
Virtual memory max (MB): 23552.00
Virtual memory used (MB): 16850.39
Swap memory total (MB): 7168.00
Swap memory used (MB): 6821.50
JVM Flags: 7 total; -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=16M -Xmx6144m
Fabric Mods:
betterf3: BetterF3 9.0.0
cloth-config: Cloth Config v13 13.0.114
cloth-basic-math: cloth-basic-math 0.6.1
disableinsecurechattoast: Disable Insecure Chat Toast 1.1.0
fabric-api: Fabric API 0.95.1+1.20.4
fabric-api-base: Fabric API Base 0.4.36+78d798af4f
fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.47+82b1bb3e4f
fabric-biome-api-v1: Fabric Biome API (v1) 13.0.16+78d798af4f
fabric-block-api-v1: Fabric Block API (v1) 1.0.15+78d798af4f
fabric-block-view-api-v2: Fabric BlockView API (v2) 1.0.4+78d798af4f
fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.46+78d798af4f
fabric-client-tags-api-v1: Fabric Client Tags 1.1.7+78d798af4f
fabric-command-api-v1: Fabric Command API (v1) 1.2.41+f71b366f4f
fabric-command-api-v2: Fabric Command API (v2) 2.2.20+78d798af4f
fabric-commands-v0: Fabric Commands (v0) 0.2.58+df3654b34f
fabric-containers-v0: Fabric Containers (v0) 0.1.86+df3654b34f
fabric-content-registries-v0: Fabric Content Registries (v0) 5.0.10+78d798af4f
fabric-convention-tags-v1: Fabric Convention Tags 1.5.10+78d798af4f
fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.23+78d798af4f
fabric-data-attachment-api-v1: Fabric Data Attachment API (v1) 1.0.0+25e1b4764f
fabric-data-generation-api-v1: Fabric Data Generation API (v1) 13.1.22+78d798af4f
fabric-dimensions-v1: Fabric Dimensions API (v1) 2.1.61+78d798af4f
fabric-entity-events-v1: Fabric Entity Events (v1) 1.6.0+44c0f8c64f
fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.7.1+389931eb4f
fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.72+df3654b34f
fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.46+78d798af4f
fabric-item-api-v1: Fabric Item API (v1) 2.2.0+d6f2b0844f
fabric-item-group-api-v1: Fabric Item Group API (v1) 4.0.21+78d798af4f
fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.41+78d798af4f
fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.39+df3654b34f
fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.2.30+78d798af4f
fabric-loot-api-v2: Fabric Loot API (v2) 2.1.5+78d798af4f
fabric-message-api-v1: Fabric Message API (v1) 6.0.5+78d798af4f
fabric-mining-level-api-v1: Fabric Mining Level API (v1) 2.1.60+78d798af4f
fabric-model-loading-api-v1: Fabric Model Loading API (v1) 1.0.8+78d798af4f
fabric-models-v0: Fabric Models (v0) 0.4.7+9386d8a74f
fabric-networking-api-v1: Fabric Networking API (v1) 3.1.7+2e5ac5484f
fabric-object-builder-api-v1: Fabric Object Builder API (v1) 13.0.9+06274a474f
fabric-particles-v1: Fabric Particles (v1) 1.1.7+78d798af4f
fabric-recipe-api-v1: Fabric Recipe API (v1) 2.0.20+78d798af4f
fabric-registry-sync-v0: Fabric Registry Sync (v0) 4.0.18+78d798af4f
fabric-renderer-api-v1: Fabric Renderer API (v1) 3.2.4+78d798af4f
fabric-renderer-indigo: Fabric Renderer - Indigo 1.5.4+78d798af4f
fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.52+df3654b34f
fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.42+73761d2e4f
fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.0.33+78d798af4f
fabric-rendering-v0: Fabric Rendering (v0) 1.1.55+df3654b34f
fabric-rendering-v1: Fabric Rendering (v1) 3.1.0+0d29db764f
fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 2.3.14+78d798af4f
fabric-screen-api-v1: Fabric Screen API (v1) 2.0.17+78d798af4f
fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.3.55+78d798af4f
fabric-sound-api-v1: Fabric Sound API (v1) 1.0.17+78d798af4f
fabric-transfer-api-v1: Fabric Transfer API (v1) 4.0.8+e84342304f
fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 5.0.14+78d798af4f
fabric-language-kotlin: Fabric Language Kotlin 1.10.17+kotlin.1.9.22
org_jetbrains_kotlin_kotlin-reflect: kotlin-reflect 1.9.22
org_jetbrains_kotlin_kotlin-stdlib: kotlin-stdlib 1.9.22
org_jetbrains_kotlin_kotlin-stdlib-jdk7: kotlin-stdlib-jdk7 1.9.22
org_jetbrains_kotlin_kotlin-stdlib-jdk8: kotlin-stdlib-jdk8 1.9.22
org_jetbrains_kotlinx_atomicfu-jvm: atomicfu-jvm 0.23.1
org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm: kotlinx-coroutines-core-jvm 1.7.3
org_jetbrains_kotlinx_kotlinx-coroutines-jdk8: kotlinx-coroutines-jdk8 1.7.3
org_jetbrains_kotlinx_kotlinx-datetime-jvm: kotlinx-datetime-jvm 0.5.0
org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm: kotlinx-serialization-cbor-jvm 1.6.2
org_jetbrains_kotlinx_kotlinx-serialization-core-jvm: kotlinx-serialization-core-jvm 1.6.2
org_jetbrains_kotlinx_kotlinx-serialization-json-jvm: kotlinx-serialization-json-jvm 1.6.2
fabricloader: Fabric Loader 0.15.6
mixinextras: MixinExtras 0.3.2
ias: In-Game Account Switcher 8.0.2
inventoryprofilesnext: Inventory Profiles Next 1.10.9
inventorytabs: Inventory Tabs 0.9.0-beta-1.20
itemswapper: ItemSwapper 0.5.5
jade: Jade 13.2.1
java: OpenJDK 64-Bit Server VM 17
jei: Just Enough Items 17.3.0.48
jeresources: Just Enough Resources 1.4.1.246
lambdynlights: LambDynamicLights 2.3.4+1.20.4
pride: Pride Lib 1.2.0+1.19.4
spruceui: SpruceUI 5.0.3+1.20.2
libipn: libIPN 4.0.1
lithium: Lithium 0.12.1
malilib: MaLiLib 0.18.1
minecraft: Minecraft 1.20.4
minihud: MiniHUD 0.30.2
modmenu: Mod Menu 9.0.0
reeses-sodium-options: Reese's Sodium Options 1.7.2+mc1.20.4-build.102
sodium: Sodium 0.5.8+mc1.20.4
fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.11.17+707e4d1b4f
sodium-extra: Sodium Extra 0.5.4+mc1.20.4-build.116
caffeineconfig: CaffeineConfig 1.3.0+1.17
crowdin-translate: CrowdinTranslate 1.4+1.19.3
starlight: Starlight 1.1.3+fabric.f5dcd1a
worldedit: WorldEdit 7.2.18+6616-abda4e0
xaerominimap: Xaero's Minimap 23.9.7
xaeroworldmap: Xaero's World Map 1.37.8
Launched Version: fabric-loader-0.15.6-1.20.4
Launcher name: java-minecraft-launcher
Backend library: LWJGL version 3.3.2-snapshot
Backend API: AMD Radeon Pro 555X OpenGL Engine GL version 4.1 ATI-4.8.101, ATI Technologies Inc.
Window size: 1708x960
GL Caps: Using framebuffer using OpenGL 3.2
GL debug messages: <disabled>
Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'fabric'
Universe: 400921fb54442d18
Type: Client (map_client.txt)
Graphics mode: fast
Render Distance: 12/12 chunks
Resource Packs: vanilla, file/Ancient Debris (incompatible), file/Netherrack (incompatible), fabric, itemswapper:experimental_addon, itemswapper:classic, itemswapper:default
Current Language: en_us
Locale: ja_HK
CPU: 12x Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Big fan. Updated it so I can keep using it!
I noticed that it uses cloth and modmenu. Note that they aren't released for 1.20-pre2 yet, so this is not production-ready, but the actual mod functionality is working all well.
Changes:
entity.world
with vanilla getterTest screenshot: