search

Andrew6rant / Stacker

Minecraft mod to change the stack size of all items. Fabric 1.19, 1.18, and 1.17.
Creative Commons Zero v1.0 Universal
26 stars 17 forks source link

Divide by Zero crash #17

Closed jigoralpsi closed 2 years ago

jigoralpsi commented 2 years ago

With stacker installed at all, attempting to put any stackable item into a Bundle causes immediate crash with a divide by zero error. Disabling stacker allows bundle usage. Leaving stacker max stack size at default still allows issue to occur.

Crashlog: https://pastebin.com/EjZQqCRh

Andrew6rant commented 2 years ago

Thnak you for the issue report! I believe this is because Stacker (well, Stacc API in Stacker) changes the item storage from byte to int. Looks like I need to mixin into addToBundle if I want bundles to accept any item.

This is actually not something I think I will fix until 1.18, or whenever bundles release. Right now, they are not supported by the game and buggy (for example, they don't work unless you have the default keybinds)

jigoralpsi commented 2 years ago

Fair enough. I was just figuring out why I was crashing while being a lootgoblin before finding/building a nice location for a base. Lol. Thanks for the mod, I'll definately update when MC does. :)

Andrew6rant commented 2 years ago

The bundle crash is fixed as of version 3.0.0 (Thanks to a mixin by Devan-Kerman)