Andrew6rant / Thanks--I-fixed-your-Inventory

Customize several aspects of the player inventory. Slot x/y positions, highlight color, player render, etc.
MIT License
2 stars 0 forks source link

compat with trinkets slot #2

Open dadoirie opened 1 year ago

dadoirie commented 1 year ago

Can TIFYI tap into Trinkets slots? Giving it optional compatibility if trinkets is present? image basically only the 3 red marked ones - the left outer ones ain't needed

EDIT: don't worry about the offhand/shield thingy - it's just me using the inventory.png from TIFYI with vanilla slot configs

Andrew6rant commented 1 year ago

Yeah, I'll look into supporting Trinkets' slots in TIFYI. Trinkets doesn't have a way to change slot locations in their API so I have to write some really gross code to hook into it.

I've actually done it before, for another project of mine, LittleBigInv: https://github.com/Andrew6rant/BigInv. (see how the minecart slot and disabled slots are aligned with the offhand icon)

LittleBigInv Showcase

That mod hard depends on Trinkets, so I can directly modify its code. I don't want to do that for this mod, so I also need to make a mixin plugin.

dadoirie commented 1 year ago

if this would be possible - these for on the left moving inside image

then also the book and text needs to be able to move image

dadoirie commented 1 year ago

you know what: if you're making more trinkets slots available inside could you make this optional if wanna more trinkets slots inside? - since I'm planning to release the resourcepack and will make 2 kinds of textures - one with more trinkets inside and the other with just 3 trinkets inside and the rest outside using Respackopts for this - which also has conditions if a certain mod is loaded

Andrew6rant commented 1 year ago

TIFYI will not move the trinkets slots on the left to the right, that can be done through datapacks with just Trinkets API, I'm pretty sure. I can definitely allow for the recipe book and "Crafting" text to be moved though.

Also, would it be better if I made the inventory texture changes an embedded resource pack, instead of always-enabled?

dadoirie commented 1 year ago

regarding trinkets I believe via datapacks are only added slots ... theirs placement is coded

as seen on the screenshots those 3 trinket groups on the right and anything beyond that goes outside to the left border also just now got confirmed on trinket's discord that placements of trinkets slots are coded and can't be changed via datapack ![image](https://github.com/Andrew6rant/Thanks--I-fixed-your-Inventory/assets/61109153/e719cd26-8bbd-4cae-9b7d-a16368b89332

and regarding the embedded resourcepack sounds quite handy for users, resource pack creator might not benefit much from it unless you could use the currently active resourcepack and it's inventory.png and make something with it

examples - taking their background and modify it dynamically - I'm no coder, so wouldn't know how to accomplish that :/ don't mind it much - still under heavy WIP image image

dadoirie commented 1 year ago

well, in order to make this feature request simpler and lesser work since it's not your only mod from looking at your repo counts (busy, busy): trinket compatibility: forget about the moving the left side to the right - just being able to move the right ones - but careful tho not to move the left ones too as this might look ugly when they end up over the equipment slots about embedded resource pack do what you thing is the best for regular users - resource pack makers will need to work with it and if something not working well, they still can open issues here on github :)

Andrew6rant commented 1 year ago

I haven't started on Trinkets compat (because I need to make a mixin plugin for it), but I've implemented configs in 1.1.0 to move the recipe book and "crafting" text (also added a config to change the size of the player inventory render)

jptrzy commented 6 months ago

I haven't updated it for a while, but this mod could be relevant.