search

Andrew6rant / precise-damage

Changes damage calculations to allow for fractional values.
MIT License
5 stars 1 forks source link

Removing vanilla's armor bar could cause compatibility issues #1

Closed KxmischesDomi closed 2 years ago

KxmischesDomi commented 2 years ago

Mods that change the armor bar rendering wouldn't work anymore. Maybe there is a solution with only modifying the size of the rendered sprite or smth and not replacing the entire rendering.

https://github.com/Andrew6rant/precise-armor/blob/308da92a46c70f297793332fd1530ba57ec57089/src/main/java/io/github/andrew6rant/precise_armor_bar/mixin/client/InGameHudMixin.java#L19

Andrew6rant commented 2 years ago

The solution I have made is to split Precise Armor Bar into two mods: Precise Armor, and Precise Armor Bar.

Precise Armor is the tiny one-mixin mod that actually changes damage calculations, and Precise Armor Bar is the optional mod that changes rendering. The code for Precise Armor can be found in the "api" branch: https://github.com/Andrew6rant/precise-armor/tree/api