search

Andrew6rant / precise-damage

Changes damage calculations to allow for fractional values.
MIT License
5 stars 1 forks source link

Incompatible with Deep Mob Learning: Refabricated (Server) #3

Open Seceroth opened 1 year ago

Seceroth commented 1 year ago

Precise Armor 1.0 Deepmoblearning-refabricated-1.18.2 Fabric-loader-0.14.8 Fabric-api-0.57.0+1.18.2

[main/WARN]: @Redirect conflict. Skipping precise_armor.mixins.json:LivingEntityMixin from mod precise_armor->@Redirect::applyArmorToDamage(FFF)F with priority 1000, already redirected by mixins.dml-refabricated-modular-armor.json:LivingEntityMixin from mod dml-refabricated-modular-armor->@Redirect::glitchArmorUncapProtection(FFFLnet/minecraft/class_1282;F)F with priority 1000 [main/ERROR]: Failed to start the minecraft server java.lang.RuntimeException: Mixin transformation of net.minecraft.class_1309 failed

Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector applyArmorToDamage(FFF)F in precise_armor.mixins.json:LivingEntityMixin from mod precise_armor failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap precise_armor-refmap.json

Andrew6rant commented 1 year ago

It looks like Deep Mob Learning redirects at the same spot that I do, to allow for their ItemModularGlitchArmor to have an uncapped protection value.

https://github.com/CafeteriaGuild/DeepMobLearning-Refabricated/blob/main/modular-armor/src/main/java/dev/nathanpb/dml/modular_armor/mixin/LivingEntityMixin.java#L102-L114

I think that mod needs to change the redirect into a less-invasive inject.

NathanPB commented 1 year ago

Would you suggest anything? I don't have much idea on what to do