AndrewAnnex / SpiceyPy

SpiceyPy: a Pythonic Wrapper for the SPICE Toolkit.
MIT License
398 stars 84 forks source link

refactor get_spice to build from source #424

Closed AndrewAnnex closed 3 years ago

AndrewAnnex commented 3 years ago

this is a big refactor of get_spice.py to allow spiceypy to build spice from source, apply patches from the NAIF, enabling ARM builds. Changes the names of some things so likely a bit broken.

pep8speaks commented 3 years ago

Hello @AndrewAnnex! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Comment last updated at 2021-10-20 17:29:47 UTC
codecov[bot] commented 3 years ago

Codecov Report

Merging #424 (5f30355) into main (73bba45) will decrease coverage by 0.02%. The diff coverage is 66.66%.

:exclamation: Current head 5f30355 differs from pull request most recent head c8ea43c. Consider uploading reports for the commit c8ea43c to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   99.87%   99.85%   -0.03%     
==========================================
  Files          12       12              
  Lines       14750    14752       +2     
==========================================
- Hits        14732    14731       -1     
- Misses         18       21       +3     
Impacted Files Coverage Δ
spiceypy/utils/libspicehelper.py 99.85% <66.66%> (-0.15%) :arrow_down:
spiceypy/spiceypy.py 99.65% <0.00%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 73bba45...c8ea43c. Read the comment docs.

AndrewAnnex commented 3 years ago

closing in favor of #428