AndrewAnnex / SpiceyPy

SpiceyPy: a Pythonic Wrapper for the SPICE Toolkit.
MIT License
398 stars 84 forks source link

Mv to src layout #427

Closed AndrewAnnex closed 3 years ago

pep8speaks commented 3 years ago

Hello @AndrewAnnex! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 147:5: E306 expected 1 blank line before a nested definition, found 0

Line 260:78: E741 ambiguous variable name 'l'

Comment last updated at 2021-10-12 13:39:03 UTC
codecov[bot] commented 3 years ago

Codecov Report

Merging #427 (3cb6ca6) into main (73bba45) will decrease coverage by 0.02%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   99.87%   99.85%   -0.03%     
==========================================
  Files          12       12              
  Lines       14750    14752       +2     
==========================================
- Hits        14732    14731       -1     
- Misses         18       21       +3     
Impacted Files Coverage Δ
src/spiceypy/__init__.py 100.00% <ø> (ø)
src/spiceypy/config.py 100.00% <ø> (ø)
src/spiceypy/spiceypy.py 99.65% <ø> (ø)
src/spiceypy/tests/gettestkernels.py 100.00% <ø> (ø)
src/spiceypy/tests/test_gettestkernels.py 100.00% <ø> (ø)
src/spiceypy/tests/test_spiceerrors.py 100.00% <ø> (ø)
src/spiceypy/tests/test_support_types.py 100.00% <ø> (ø)
src/spiceypy/tests/test_wrapper.py 100.00% <ø> (ø)
src/spiceypy/utils/callbacks.py 100.00% <ø> (ø)
src/spiceypy/utils/exceptions.py 100.00% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 73bba45...3cb6ca6. Read the comment docs.