pep8speaks commented 2 years ago

Hello @AndrewAnnex! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file get_spice.py:

Line 277:1: E302 expected 2 blank lines, found 1

In the file src/spiceypy/tests/test_wrapper.py: No issues found.

codecov[bot] commented 2 years ago

Codecov Report

Merging #439 (aba71e0) into main (836c72c) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
- Coverage   99.87%   99.87%   -0.01%     
==========================================
  Files          12       12              
  Lines       14756    14755       -1     
==========================================
- Hits        14738    14737       -1     
  Misses         18       18

Impacted Files	Coverage Δ
src/spiceypy/tests/test_wrapper.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 836c72c...aba71e0. Read the comment docs.

AndrewAnnex commented 2 years ago

the one failing test is from pointing to an n66 shared library, so it's working! just gotta decide which thing to merge first, possibly this one as I will still need to version bump spiceypy for conda-forge things.

AndrewAnnex / SpiceyPy

start of N67 support #439

Codecov Report