search

AndrewAnnex / SpiceyPy

SpiceyPy: a Pythonic Wrapper for the SPICE Toolkit.
MIT License
384 stars 84 forks source link

Implementation of sphlat calls sphcyl by mistake #471

Closed rfrenchseti closed 1 year ago

rfrenchseti commented 1 year ago

The implementation of sphlat actually calls sphcyl_c. This is obviously a typo. Note the test for sphlat is wrong as well and does not correspond to the definition of sphlat from the NAIF documentation.

AndrewAnnex commented 1 year ago

@rfrenchseti nice find, are you able to write a pull request to fix the issue?

rfrenchseti commented 1 year ago

Sorry, not at the moment. I'll let you take care of it.

fyellin commented 1 year ago

I can take care of it later this afternoon.

AndrewAnnex commented 1 year ago

@fyellin thanks that would be great, I want to issue a minor version release soon to include a fix for this