search

AndrewBarba / apns2

Node client for connecting to Apple's Push Notification Service using the new HTTP/2 protocol with JSON web tokens
MIT License
118 stars 32 forks source link

Possible typo in typings? #30

Closed ShaharHD closed 4 years ago

ShaharHD commented 4 years ago

https://github.com/AndrewBarba/apns2/blob/e6d6fbb93ef7e121d96335f35ee6c25e13de4ebd/index.d.ts#L7

Seems it should be void and not Void

AndrewBarba commented 4 years ago

Ah damn, I’ve been writing a lot more Swift than JS/TS. Will get this fixed

ShaharHD commented 4 years ago

31 created

It kept giving me errors on tsc

ShaharHD commented 4 years ago

FYI, it seems the auto build fails because of mismatch between the wrecker file and the package.json.

Is there a reason you're looking for 10.16 and not simply 10.x ?

My suggestion in any case would be to update the wrecker file file to box: node:10 and in the package.json to 

  "engines": {
    "node": "10.x"
  },

32 created as well (build passing on my fork)

image

AndrewBarba commented 4 years ago

Releasing as 8.5.0