AndrewBelt / osdialog

A cross platform wrapper for OS dialogs like file save, open, message boxes, inputs, color picking, etc.
Creative Commons Zero v1.0 Universal
122 stars 19 forks source link

Missing include in osdialog_win.c? #10

Closed MarcBoule closed 5 years ago

MarcBoule commented 5 years ago

Platfrom WIN10 Commit: 06d7e42

When I clone and make ARCH=win, I get an error on this line:

https://github.com/AndrewBelt/osdialog/blob/master/osdialog_win.c#L38 (output shown below)

Would osdialog_win.c need to include <assert.h>? Or perhaps my compiler is not up to date. In any case, feel free to close if this looks like a problem on my end only.

$ make ARCH=win
cc -std=c99 -Wall -g -o test test.c osdialog.c osdialog_win.c -lcomdlg32
osdialog_win.c: In function 'osdialog_prompt':
osdialog_win.c:38:2: warning: implicit declaration of function 'assert'; did you mean 'accept'? [-Wimplicit-function-declaration]
  assert(0);
  ^~~~~~
  accept
C:\msys64\tmp\ccBh2Lny.o: In function `osdialog_prompt':
C:\msys64\home\Admin\Rack\rdev\osdialog/osdialog_win.c:38: undefined reference to `assert'
collect2.exe: error: ld returned 1 exit status
make: *** [Makefile:29: test] Error 1
MarcBoule commented 5 years ago

Fixed in 427c736