search

AndrewBennet / ReadingListV1

:books: :iphone: Reading List - an iOS app to track personal reading lists
https://readinglist.app
GNU General Public License v3.0
300 stars 48 forks source link

Faster way to update reading progress when using Log #10

Closed skipadu closed 5 years ago

skipadu commented 5 years ago

When the book is in "Reading" state and user goes to "Log", the current page number is automatically focused and selected. Therefore the user can enter the new page right away instead of selecting and clearing the old one first. Little faster way to update the reading progress.

What do you think about this improvement?

Screenshot focusandautoselect_currentpage

AndrewBennet commented 5 years ago

You're on a roll! I will take a look at this soon 👍

AndrewBennet commented 5 years ago

If you commit those suggested changes (you can do it all at once from the Files Changed tab; I don't have rights to do it), I will merge the pull request.

Also, are you OK with me crediting you by name in the release notes when I release the next version? 😄

skipadu commented 5 years ago

Okay. Haven't used the GitHub's pull requests or like any team feature beforee, so thanks for pointing that out. Will do the commit now.

I'm honored if you can show my name in the "credits" of next version :)

AndrewBennet commented 5 years ago

Ah there's actually an issue in one of my suggested changes - that currentPageKey variable isn't in scope in the function viewDidAppear. Not to worry - I'll merge this PR and fix it on master.

Are you on the TestFlight beta testing program? If not, you could sign up here if you want; I will deploy a new version with this change soon.

skipadu commented 5 years ago

Okay 👍 Yes, I'm already on the TestFlight beta testing :)